Updated error when calling server.start with no callback

[fiveisprime]

Updated the start method of server to verify that a callback was
passed. If no callback is passed, a friendly error is thrown.

Error: A callback is required when calling server.start

This is compared to the old error which required some digging
to find the cause of the problem.

TypeError: callback is not a function

Related to #2705

[kanongil]

Nice. You should probably align the test and message with the stop() test here: https://github.com/hapijs/hapi/blob/master/lib/server.js#L258.

[fiveisprime]

Updated! Thanks for the feedback. 👍

[arb]

Can you add a test for this as well?

[fiveisprime]

Done.

[spiralni]

@fiveisprime thanks for your contribution!

It's very nice to have descriptive exceptions. I like the way "windsor" library shows its errors, very verbose and including way to fix them.
Maybe we can include a little example showing how it must to be done. It is just an idea.

This is an example:

Source: http://kozmic.net/2011/02/16/windsors-longest-exception-message-just-got-longer/

[fiveisprime]

@spiralni That's awesome! I can do something like this, but in a different pull
request since it will touch a lot more than just the start.

I love this idea. :)

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.