Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preload flag to HSTS header and fix casing for includeSubDomains. #2776

Merged
merged 2 commits into from Sep 25, 2015

Conversation

@analytically
Copy link
Contributor

@analytically analytically commented Sep 20, 2015

See https://scotthelme.co.uk/hsts-preloading/ for more information.

Also fixes casing issue in HSTS header: includeSubDomains - http://tools.ietf.org/html/rfc6797.

@devinivy
Copy link
Member

@devinivy devinivy commented Sep 21, 2015

I can't say for sure whether or not this will be an accepted feature, but the PR will likely need to adjust the casing of includeSubDomains vs includeSubdomains in the existing tests and include an additional test for the new option to be considered. Additionally, the options schema would need to be adjusted around here: https://github.com/hapijs/hapi/blob/master/lib/schema.js#L116. It does seem like the casing of includeSubDomains in this PR is preferred, based upon other examples on the web.

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Sep 21, 2015

@nlf?

@nlf
Copy link
Member

@nlf nlf commented Sep 21, 2015

this gets a +1 from me, looks good

@devinivy
Copy link
Member

@devinivy devinivy commented Sep 21, 2015

Is this our first case of releasing a feature to 10.x and hapi-lts?

@analytically analytically changed the title Add preload flag to HSTS header. Add preload flag to HSTS header and fix casing for includeSubDomains. Sep 23, 2015
@hueniverse hueniverse added this to the 10.0.2 milestone Sep 25, 2015
@hueniverse hueniverse self-assigned this Sep 25, 2015
hueniverse added a commit that referenced this issue Sep 25, 2015
Add preload flag to HSTS header and fix casing for includeSubDomains.
@hueniverse hueniverse merged commit e3b8082 into hapijs:master Sep 25, 2015
1 check passed
@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants