-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Expanded registrations API. Added test. Updated docs.
#2829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Any reason the |
|
Yes the |
|
Hmm. The schema has the '0.0.0' default. Is it not working right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just item as a whole?
|
@hueniverse it works right if your plugin has |
|
The we need to fix the schema, not the code. |
|
@hueniverse updated schema so we could remove the |
lib/plugin.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is redundant given you have attributes.
|
This should be good for a second review. |
Expanded `registrations` API. Added test. Updated docs.
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Added more information to the plugin results of
registrations.