Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Accept' to default header per #2855 #2858

Merged
merged 3 commits into from
Oct 20, 2015
Merged

Add 'Accept' to default header per #2855 #2858

merged 3 commits into from
Oct 20, 2015

Conversation

AdriVanHoudt
Copy link
Contributor

PR request by @hueniverse in #2855
I hope I interpreted the PR right.

@@ -2110,7 +2110,7 @@ following options:
('Access-Control-Max-Age'). The greater the value, the longer it will take before the
browser checks for changes in policy. Defaults to `86400` (one day).
- `headers` - a strings array of allowed headers ('Access-Control-Allow-Headers').
Defaults to `['Authorization', 'Content-Type', 'If-None-Match']`.
Defaults to `['Authorization', 'Content-Type', 'If-None-Match', 'Accept']`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's alphabetical...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't think about that, fixed

@hueniverse hueniverse added feature New functionality or improvement breaking changes Change that can breaking existing code security Issue with security impact labels Oct 19, 2015
@hueniverse hueniverse self-assigned this Oct 19, 2015
@hueniverse hueniverse added this to the 11.0.1 milestone Oct 20, 2015
hueniverse added a commit that referenced this pull request Oct 20, 2015
@hueniverse hueniverse merged commit 234c23a into hapijs:master Oct 20, 2015
@AdriVanHoudt AdriVanHoudt deleted the cors-accept-header branch October 20, 2015 06:25
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking changes Change that can breaking existing code feature New functionality or improvement security Issue with security impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants