Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error messages to 404's caused by cors closes #2857 #2859

Merged
merged 2 commits into from Oct 20, 2015
Merged

Add error messages to 404's caused by cors closes #2857 #2859

merged 2 commits into from Oct 20, 2015

Conversation

@AdriVanHoudt
Copy link
Contributor

@AdriVanHoudt AdriVanHoudt commented Oct 19, 2015

Closes #2857

@AdriVanHoudt
Copy link
Contributor Author

@AdriVanHoudt AdriVanHoudt commented Oct 19, 2015

Btw any comments about the messages welcome, just put ones there that made sense to me.

}

// Lookup route

var route = request.connection.match(method, request.path, request.headers.host);
if (!route) {
return reply(Boom.notFound());
return reply(Boom.notFound('Missing route'));
Copy link
Contributor

@hueniverse hueniverse Oct 19, 2015

This is a classic not found. No need for a message.

@hueniverse hueniverse self-assigned this Oct 19, 2015
@AdriVanHoudt
Copy link
Contributor Author

@AdriVanHoudt AdriVanHoudt commented Oct 19, 2015

Updated the messages

@hueniverse hueniverse added this to the 11.0.1 milestone Oct 20, 2015
hueniverse added a commit that referenced this issue Oct 20, 2015
Add error messages to 404's caused by cors closes #2857
@hueniverse hueniverse merged commit 2018ff8 into hapijs:master Oct 20, 2015
1 check passed
@AdriVanHoudt AdriVanHoudt deleted the cors-404-reasons branch Oct 20, 2015
@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants