Add error messages to 404's caused by cors closes #2857#2859
Merged
hueniverse merged 2 commits intohapijs:masterfrom Oct 20, 2015
AdriVanHoudt:cors-404-reasons
Merged
Add error messages to 404's caused by cors closes #2857#2859hueniverse merged 2 commits intohapijs:masterfrom AdriVanHoudt:cors-404-reasons
hueniverse merged 2 commits intohapijs:masterfrom
AdriVanHoudt:cors-404-reasons
Conversation
Contributor
Author
|
Btw any comments about the messages welcome, just put ones there that made sense to me. |
lib/cors.js
Outdated
Contributor
There was a problem hiding this comment.
This is a classic not found. No need for a message.
Contributor
Author
|
Updated the messages |
hueniverse
added a commit
that referenced
this pull request
Oct 20, 2015
Add error messages to 404's caused by cors closes #2857
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2857