Fixed an issue with mixed-case headers not being matched correctly in CORS#2866
Closed
giovannicalo wants to merge 1 commit intohapijs:masterfrom
giovannicalo:master
Closed
Fixed an issue with mixed-case headers not being matched correctly in CORS#2866giovannicalo wants to merge 1 commit intohapijs:masterfrom giovannicalo:master
giovannicalo wants to merge 1 commit intohapijs:masterfrom
giovannicalo:master
Conversation
Contributor
|
Thanks. Did it a bit differently to make runtime faster. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the CORS rework, headers seem to be matched in a case-sensitive way.
Therefore, even if a header is allowed...
... and the browser sends it (with a different case)...
... it won't match, thus causing the CORS preflight request to fail.
This fixes it.
The horrible blank lines are there to please the linter.
Feel free to rewrite it differently.