Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with mixed-case headers not being matched correctly in CORS #2866

Closed
wants to merge 1 commit into from
Closed

Conversation

@giovannicalo
Copy link
Contributor

@giovannicalo giovannicalo commented Oct 21, 2015

After the CORS rework, headers seem to be matched in a case-sensitive way.
Therefore, even if a header is allowed...

cors: {
    additionalHeaders: [
        "X-Requested-With"
    ]
}

... and the browser sends it (with a different case)...

Access-Control-Request-Headers: x-requested-with

... it won't match, thus causing the CORS preflight request to fail.

This fixes it.

The horrible blank lines are there to please the linter.
Feel free to rewrite it differently.

@hueniverse hueniverse added the bug label Oct 21, 2015
@hueniverse hueniverse self-assigned this Oct 21, 2015
@hueniverse hueniverse added this to the 11.0.2 milestone Oct 21, 2015
@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Oct 21, 2015

Thanks. Did it a bit differently to make runtime faster.

@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants