Fails to set a global route auth config#2940
Merged
hueniverse merged 2 commits intohapijs:masterfrom Nov 21, 2015
giovannicalo:master
Merged
Fails to set a global route auth config#2940hueniverse merged 2 commits intohapijs:masterfrom giovannicalo:master
hueniverse merged 2 commits intohapijs:masterfrom
giovannicalo:master
Conversation
…ication if set globally
Contributor
|
Can you add a test that fails without your changes and passes with them? |
hueniverse
added a commit
that referenced
this pull request
Nov 21, 2015
Fails to set a global route auth config
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the recent special routes changes, a server configured to use an authentication strategy by default for all routes...
... would fail to start and instead throw an error.
I also doubt the special routes are supposed to require authentication in the first place, as they didn't till the aforementioned commit.
This fixes it.
However, it might be better to just ignore authentication-related options for routes where
method === "_special", instead of passingconfig: { auth: false }every time.