Add validation check for stripUnknown route response option#2972
Merged
hueniverse merged 2 commits intohapijs:masterfrom Dec 22, 2015
johnbrett:master
Merged
Add validation check for stripUnknown route response option#2972hueniverse merged 2 commits intohapijs:masterfrom johnbrett:master
hueniverse merged 2 commits intohapijs:masterfrom
johnbrett:master
Conversation
Contributor
|
You made travis sad... Just remove the trailing spaces. |
hueniverse
added a commit
that referenced
this pull request
Dec 22, 2015
Add validation check for stripUnknown route response option
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might save someone some time debugging in the future. Currently we can add:
Which actually wouldn't strip any unknown keys without the
modifykey set true. With this PR if we add a route with response optionstripUnknownset true withoutmodifyset to true, it will throw a validation error.