Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle more types of promise rejection, for #3102 #3201

Merged
merged 1 commit into from
Aug 22, 2016
Merged

Conversation

nlf
Copy link
Member

@nlf nlf commented Jun 10, 2016

the only thing this doesn't cover from that issue is adding an unhandledRejection handler, which i'm still not sure how i feel about anyway

@devinivy
Copy link
Member

devinivy commented Jun 10, 2016

Looks good to me. I don't love the prospect of an unhandledRejection handler. Maybe it could be opt-in.

@hueniverse hueniverse added the bug Bug or defect label Aug 22, 2016
@hueniverse hueniverse added this to the 15.0.0 milestone Aug 22, 2016
@hueniverse hueniverse self-assigned this Aug 22, 2016
@hueniverse hueniverse merged commit 7e66adc into master Aug 22, 2016
@hueniverse hueniverse deleted the promises branch August 22, 2016 08:11
hueniverse added a commit that referenced this pull request Aug 22, 2016
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug or defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants