Attempt to fix #3399 where it crashes on route prerequisites when no domain is present - #3401
Merged
Merged
Conversation
sirgallifrey
changed the title
Contributor
|
Don't apologize in advance (or after the fact for that matter) for making a mistake. I don't know if you have, I'm just saying in general. I appreciate the effort. I'll review this week. |
Contributor
|
I'll be able to test this PR on my machine environment later today. |
Contributor
|
@sirgallifrey yeah no need to say sorry, we appreciate every contribution very much! |
Contributor
|
This PR solves the bug ! Not much else to say, it used not to work, now it does. Thank you very much everyone. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote a failing test witch match the description on #3399 and added a check to see if domain exists before binding. I also changed
domain = process.domaintodomain = request.domainto prevent the test domain from being used.I'm sorry in advance if this fix is no good, I just recently started to studying the hapi internals