Fix several request.url property issues on setUrl()#3441
Merged
hueniverse merged 3 commits intohapijs:masterfrom May 30, 2017
Merged
Fix several request.url property issues on setUrl()#3441hueniverse merged 3 commits intohapijs:masterfrom
hueniverse merged 3 commits intohapijs:masterfrom
Conversation
Contributor
Author
|
I added another commit to fix the issues in #3430. |
Contributor
|
Why are you preserving the port number when the new host doesn't have one? |
Contributor
Author
|
I'm not sure. It must have seemed sensible at the time, but using the default port for the scheme also makes sense. This way it is more similar to a redirect. |
* The passed url object is not cloned. * Trailing slash stripping should be done after normalization (important if hapijs/call#29 is implemented). * Always update pathname derived url properties when path is modified.
Contributor
|
If you are going to provide a new full URI, it should override everything including the port. |
kanongil
force-pushed
the
revise-normalize
branch
from
221c158 to
081f365
Compare
Contributor
Author
|
Ok, I have rebased and revised the info update. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes this following issues in the
request.setUrl()method:This should make for a safer and more consistent
request.setUrl()experience.