Bind request continuation methods to current domain#3448
Merged
hueniverse merged 1 commit intohapijs:masterfrom May 29, 2017
Merged
Bind request continuation methods to current domain#3448hueniverse merged 1 commit intohapijs:masterfrom
hueniverse merged 1 commit intohapijs:masterfrom
Conversation
Contributor
Author
|
Note that this doesn't fix it completely for extended methods, like inert's |
Member
|
Is there a specific reason the same fix for decorations is omitted (as you've mentioned)? |
Contributor
Author
|
Mostly I only thought about it after I submitted the PR. Secondly, there is no way to know if the decoration is a continuation method, though we could just always bind the method to the domain to be safe. Let me know if you want me to update the PR. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for outmoded/discuss#445.
This ensures that any built-in request continuation methods are called using the correct domain. This is needed since promises lose the domain binding when eg.
reply()is called inside a.then().