Send connection close when there is unconsumed payload#3472
Merged
hueniverse merged 5 commits intohapijs:masterfrom May 29, 2017
Merged
Send connection close when there is unconsumed payload#3472hueniverse merged 5 commits intohapijs:masterfrom
hueniverse merged 5 commits intohapijs:masterfrom
Conversation
Contributor
|
The test on this PR is flaky. I get a 400 |
kanongil
added a commit
to kanongil/hapi
that referenced
this pull request
May 29, 2017
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
payload.output === 'stream', there is no guarantee or requirement that the user consumes the incoming payload. When a response is sent with an unconsumed payload, the connection needs to be closed to signal that the payload has been discarded. This is best done by adding theconnection: closeheader to the response.Note that node.js clients might not actually be able to handle such a response right now, due to nodejs/node#12339.