New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json escape option #3506

Merged
merged 8 commits into from Aug 5, 2017

Conversation

Projects
None yet
3 participants
@g-k
Contributor

g-k commented May 31, 2017

refs: hapijs/hoek#204

Adds the json.escape option to call hoek.escapeJSON on the JSON output. It's disabled by default.

There's probably a better place and name for this option.

Show outdated Hide outdated API.md
Show outdated Hide outdated package.json
@@ -800,6 +800,26 @@ describe('Response', () => {
});
});
describe('escape()', () => {

This comment has been minimized.

@AdriVanHoudt

AdriVanHoudt Jun 1, 2017

Member

Add a test with a success case as well for .escape()

@AdriVanHoudt

AdriVanHoudt Jun 1, 2017

Member

Add a test with a success case as well for .escape()

@AdriVanHoudt

This comment has been minimized.

Show comment
Hide comment
@AdriVanHoudt

AdriVanHoudt Jun 1, 2017

Member

Also CI is failing since, I think, hapi uses a shrinkwrap that causes it to install hoek@4 and not the latest version you told it to in the package.json. A new version of hoek would solve this.

Member

AdriVanHoudt commented Jun 1, 2017

Also CI is failing since, I think, hapi uses a shrinkwrap that causes it to install hoek@4 and not the latest version you told it to in the package.json. A new version of hoek would solve this.

@hueniverse

This comment has been minimized.

Show comment
Hide comment
@hueniverse

hueniverse Jul 17, 2017

Member

@g-k you still have some open comments above (beside the missing hoek version).

Member

hueniverse commented Jul 17, 2017

@g-k you still have some open comments above (beside the missing hoek version).

g-k and others added some commits Jul 18, 2017

@hueniverse hueniverse self-assigned this Aug 5, 2017

@hueniverse hueniverse added this to the 16.5.3 milestone Aug 5, 2017

@hueniverse hueniverse merged commit 8d1e4e6 into hapijs:master Aug 5, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Node Security No known vulnerabilities found
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment