Fixed validation of server's Joi options#3520
Closed
jgburet wants to merge 1 commit intohapijs:masterfrom
Brigad:validationOptions/stripUnknown
Closed
Fixed validation of server's Joi options#3520jgburet wants to merge 1 commit intohapijs:masterfrom Brigad:validationOptions/stripUnknown
jgburet wants to merge 1 commit intohapijs:masterfrom
Brigad:validationOptions/stripUnknown
Conversation
stripUnknown & modify coupling, when stripUnknown is having an object
Contributor
|
This was too complicated. I kept it simple. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered an error when trying to pass this to my server:
...telling me
stripUnknowndidn'tmeet requirement of having peer modify set to true.It happened the validation made in Hapi was asserting stripUnknown was matching the validation of
modify: a boolean. However, the documentation specifiesstripUnknwoncan also take an object.Just to make a remark about my commit; I'm kind of disappointed to provide the validations for the inner values of the object here because I feel like this is not the job it is intended to. Especially since I'm not doing it there as it is resolved later by Joi itself.
I would prefer to stick with a simple:
Any preference?