Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add payload fail action custom handler #3539

Merged
merged 6 commits into from Jul 18, 2017
Merged

Add payload fail action custom handler #3539

merged 6 commits into from Jul 18, 2017

Conversation

@jeff-kilbride
Copy link
Contributor

@jeff-kilbride jeff-kilbride commented Jul 14, 2017

Hi All,

This PR adds a custom handler implementation to the route payload failAction, much like the route validate failAction. It addresses #3509.

I have also added tests for the three string failAction types, along with a test for the new functionality.

I'm consistently getting an error in one test locally that was present before I made these changes:

Failed tests:

  757) transmission transmit() handles stream errors on the response after the response has been piped (inject):

      Timed out (3000ms) - transmission transmit() handles stream errors on the response after the response has been piped (inject)

Just a head's up.

Thanks!

@jeff-kilbride
Copy link
Contributor Author

@jeff-kilbride jeff-kilbride commented Jul 14, 2017

I'm using node v6.11.0 locally and it looks like the error I'm getting is also showing up in travis in v4 and v6. It also looks like v4 handles the payload error logged to request-internal a bit differently.

@hueniverse hueniverse self-assigned this Jul 18, 2017
@hueniverse hueniverse added this to the 16.5.0 milestone Jul 18, 2017
@hueniverse hueniverse merged commit b947831 into hapijs:master Jul 18, 2017
2 checks passed
hueniverse added a commit that referenced this issue Jul 18, 2017
@jeff-kilbride jeff-kilbride deleted the feature/payload_failAction_custom_handler branch Aug 1, 2017
@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants