Add payload fail action custom handler#3539
Merged
hueniverse merged 6 commits intohapijs:masterfrom Jul 18, 2017
jeff-kilbride:feature/payload_failAction_custom_handler
Merged
Add payload fail action custom handler#3539hueniverse merged 6 commits intohapijs:masterfrom jeff-kilbride:feature/payload_failAction_custom_handler
hueniverse merged 6 commits intohapijs:masterfrom
jeff-kilbride:feature/payload_failAction_custom_handler
Conversation
Contributor
Author
|
I'm using node v6.11.0 locally and it looks like the error I'm getting is also showing up in |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi All,
This PR adds a custom handler implementation to the route payload failAction, much like the route validate failAction. It addresses #3509.
I have also added tests for the three string failAction types, along with a test for the new functionality.
I'm consistently getting an error in one test locally that was present before I made these changes:
Just a head's up.
Thanks!