Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix response.message(httpMessage) #3560

Merged
merged 2 commits into from Aug 5, 2017
Merged

fix response.message(httpMessage) #3560

merged 2 commits into from Aug 5, 2017

Conversation

@amincheloh
Copy link
Contributor

@amincheloh amincheloh commented Aug 3, 2017

res.statusMessage should assign before calling res.writeHead() explicitly. see https://nodejs.org/api/http.html#http_response_statusmessage

res.statusMessage should assign before calling res.writeHead() explicitly. see https://nodejs.org/api/http.html#http_response_statusmessage
@kanongil
Copy link
Contributor

@kanongil kanongil commented Aug 3, 2017

Looks legit – thanks.

Can you add a test as well?

@amincheloh
Copy link
Contributor Author

@amincheloh amincheloh commented Aug 4, 2017

@kanongil added

@hueniverse hueniverse self-assigned this Aug 5, 2017
@hueniverse hueniverse added the bug label Aug 5, 2017
@hueniverse hueniverse added this to the 16.6.0 milestone Aug 5, 2017
@hueniverse hueniverse merged commit 5c9281d into hapijs:master Aug 5, 2017
2 checks passed
@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants