Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support joi 11 paths arrays. Fixes #3581. #3582

Merged
merged 1 commit into from Sep 24, 2017
Merged

Support joi 11 paths arrays. Fixes #3581. #3582

merged 1 commit into from Sep 24, 2017

Conversation

@Marsup
Copy link
Contributor

@Marsup Marsup commented Sep 21, 2017

I went with preserving the old response format, but this begs the question of whether it should send back keys as strings or array of strings now that it's possible. Thoughts ?

@Marsup Marsup requested a review from hueniverse Sep 21, 2017
@hueniverse hueniverse added this to the 16.6.1 milestone Sep 24, 2017
@hueniverse hueniverse self-assigned this Sep 24, 2017
@hueniverse hueniverse merged commit 5af4d2c into master Sep 24, 2017
3 checks passed
@hueniverse hueniverse deleted the joi11-paths branch Sep 24, 2017
Copy link
Contributor

@hueniverse hueniverse left a comment

LGTM

@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants