Add negative test on registering plugin twice without once#3632
Merged
hueniverse merged 1 commit intohapijs:masterfrom Oct 21, 2017
Merged
Add negative test on registering plugin twice without once#3632hueniverse merged 1 commit intohapijs:masterfrom
once#3632hueniverse merged 1 commit intohapijs:masterfrom
Conversation
…API.md phrasing around `once`.
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a negative test around registering the same plugin multiple times with
oncedefaulted tofalse. This test is to clarify the intent of theonceflag by displaying the difference in behavior when it is not set.API.md is also updated to reflect the behavior now that
connectionsare removed.NOTE: I actually think that
oncecan be deprecated entirely, and the defaultError: Plugin ___ already registeredused for all subsequent registrations. Please let me know if you'd like me to do that instead and I will close this PR and open a new one to removeonceentirely.