Loosen sample and modify peer validator in the routeBase schema#3663
Merged
Conversation
hueniverse
suggested changes
Oct 27, 2017
| .default() | ||
| .without('modify', 'sample') | ||
| .assert('options.stripUnknown', Joi.when('modify', { is: true, otherwise: Joi.forbidden() }), 'meet requirement of having peer modify set to true'), | ||
| .assert('options.stripUnknown', Joi.when('modify', { is: true, otherwise: [Joi.boolean().valid(false), Joi.forbidden()] }), 'meet requirement of having peer modify set to true'), |
Contributor
There was a problem hiding this comment.
Do you need to keep the forbidden as alternative?
Contributor
Author
There was a problem hiding this comment.
I just keep the existing code while allowing "false" value.
Do you want me to remove the forbidden as an alternative here?
Contributor
There was a problem hiding this comment.
It's not needed because the default is optional.
rokoroku
added a commit
to rokoroku/hapi
that referenced
this pull request
Apr 23, 2018
Closed
rokoroku
added a commit
to rokoroku/hapi
that referenced
this pull request
Apr 23, 2018
rokoroku
added a commit
to rokoroku/hapi
that referenced
this pull request
Apr 23, 2018
rokoroku
added a commit
to rokoroku/hapi
that referenced
this pull request
Apr 23, 2018
rokoroku
added a commit
to rokoroku/hapi
that referenced
this pull request
Apr 23, 2018
rokoroku
added a commit
to rokoroku/hapi
that referenced
this pull request
Apr 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It fixes #3567
routeBaseschema allowssampleprops whenmodifyis set to falseoptions.stripUnknownassertion allowsfalsevalue whenmodifyis set to false