Prefer user added encoding over built-in#3717
Merged
hueniverse merged 2 commits intohapijs:masterfrom Dec 21, 2017
Merged
Conversation
benib
changed the title
Contributor
|
Thanks, can you add a test as well? |
Contributor
Author
|
@kanongil i changed the existing test to test if the added encoder is preferred over built in ones by sending Would you prefer to have a separate test instead? |
Contributor
|
Should be fine. The important part is that it would fail with the old code. |
hueniverse
added
bug
Contributor
|
I consider this a bug fix since the only reason to add a custom encoder is to give it higher priority. But also marked it as breaking as it does change existing behavior. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements #3701 and resolves outmoded/discuss#589
Please let me know if I missed anything. And thanks a lot for the great framework ❤️