Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace new Buffer() #3741

Merged
merged 1 commit into from Mar 2, 2018
Merged

Replace new Buffer() #3741

merged 1 commit into from Mar 2, 2018

Conversation

@idandagan1
Copy link
Contributor

@idandagan1 idandagan1 commented Feb 18, 2018

Hi,
This is my first PR to hapi.js, after I posted in the discuss project (Link)

This PR is related to the issue with using new Buffer(). As you probably know, new Buffer() has been deprecated due to security issues and replaced by Buffer.from().

The changes:

  • replaced all new Buffer(string) with Buffer.from(string)
  • replaced all new Buffer(size) with Buffer.alloc(size)

I followed the "contributing guidelines" including tests.

@devinivy
Copy link
Member

@devinivy devinivy commented Feb 18, 2018

It appears that the failures here are primarily due to the fact that the npm shrinkwrap needs updates (bounce to v1.2.0 so the tests can use background() and hoek to v5.0.3 to pass the nsp checks). I can confirm that a fresh install without the shrinkwrap passes all tests on node v8.9.4.

Loading

@hueniverse hueniverse self-assigned this Feb 19, 2018
@idandagan1
Copy link
Contributor Author

@idandagan1 idandagan1 commented Feb 19, 2018

@devinivy should I run full update for the shrinkwrap file? or just for those you mentioned? (bounce and hoek)

Loading

@hueniverse hueniverse merged commit 8e367bb into hapijs:master Mar 2, 2018
0 of 2 checks passed
Loading
@hueniverse hueniverse added the bug label Mar 2, 2018
@hueniverse hueniverse added this to the 17.2.2 milestone Mar 2, 2018
@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

Loading

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants