Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PATCH to created status, better error msg #3766

Merged
merged 6 commits into from Apr 2, 2018
Merged

Conversation

@bioball
Copy link
Contributor

@bioball bioball commented Mar 24, 2018

The created status code helper should also be valid at least for PATCH calls.

BTW: Should this assertion even exist? I'd be in favor of getting rid of it and allow developers break the rules as they see fit.

bioball added 2 commits Mar 24, 2018
The `created` status code helper should also be valid at least for `PATCH` calls.  I'm also not sure why this assertion even exists; I'd also be in favor of getting rid of it.
@bioball bioball changed the title Add PATCH to 201 status, better error msg Add PATCH to created status, better error msg Mar 24, 2018
@bioball bioball force-pushed the patch-1 branch 2 times, most recently from 685f51c to 2937fbb Mar 26, 2018
@hueniverse hueniverse self-assigned this Apr 2, 2018
@hueniverse hueniverse added the bug label Apr 2, 2018
@hueniverse hueniverse added this to the 17.3.1 milestone Apr 2, 2018
@hueniverse hueniverse merged commit 08734ba into hapijs:master Apr 2, 2018
2 checks passed
@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Apr 2, 2018

You can still manually do what this does and violate HTTP rules on your own...

@bioball bioball deleted the patch-1 branch Apr 2, 2018
@bioball
Copy link
Contributor Author

@bioball bioball commented Apr 2, 2018

Cool. Thanks!

@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants