Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not attach request decorations to a shared prototype, alternative approach. #3796

Merged
merged 1 commit into from May 30, 2018

Conversation

@devinivy
Copy link
Member

@devinivy devinivy commented May 30, 2018

Here I'm piggy-backing the discussion in #3795 and the initial work @cjihrig did to fix/test #3718.

This change prevents request decorations from being attached to the shared Request prototype. This was leading to decorations being leaked between servers in the same process.

@hueniverse hueniverse self-assigned this May 30, 2018
@hueniverse hueniverse added the bug label May 30, 2018
@hueniverse hueniverse added this to the 17.5.1 milestone May 30, 2018
@hueniverse hueniverse merged commit 6287f7c into hapijs:master May 30, 2018
2 checks passed
@devinivy devinivy deleted the 3718-alternative branch May 30, 2018
@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants