Skip to content

Return credentials and artifacts from server.auth.test() - #3897

Merged
hueniverse merged 1 commit into
hapijs:masterfrom
futurestudio:server-auth-test-returns-artifacts
Jan 13, 2019
Merged

hueniverse merged 1 commit into
hapijs:masterfrom
futurestudio:server-auth-test-returns-artifacts

Conversation

@marcuspoehls

@marcuspoehls marcuspoehls commented Jan 7, 2019 •

Copy link
Copy Markdown
Contributor

This PR includes a breaking change. If merged, this should be released with v18.

Previously, the credentials from the tested authentication strategy were passed through. This PR changes the return value of server.auth.test().

Changes:

  • server.auth.test() now returns an object with the properties
    • `credentials (required)
    • artifacts (optional)

PS: If merged, I’ll send another PR to update the docs

@hueniverse hueniverse self-assigned this Jan 13, 2019
@hueniverse hueniverse added feature New functionality or improvement breaking changes Change that can breaking existing code labels Jan 13, 2019
@hueniverse hueniverse added this to the 18.0.0 milestone Jan 13, 2019
@hueniverse
hueniverse merged commit ea108eb into hapijs:master Jan 13, 2019
hueniverse added a commit that referenced this pull request Jan 14, 2019
@marcuspoehls
marcuspoehls deleted the server-auth-test-returns-artifacts branch January 14, 2019 09:16
@marcuspoehls

Copy link
Copy Markdown
Contributor Author

@hueniverse Eran, thank you for the additional commit to update the API.md! Thanks for merging 😊

@lock

lock Bot commented Jan 9, 2020

Copy link
Copy Markdown

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock Bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

breaking changes Change that can breaking existing code feature New functionality or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants