Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return credentials and artifacts from server.auth.test() #3897

Merged

Conversation

@marcuspoehls
Copy link
Contributor

@marcuspoehls marcuspoehls commented Jan 7, 2019

This PR includes a breaking change. If merged, this should be released with v18.

Previously, the credentials from the tested authentication strategy were passed through. This PR changes the return value of server.auth.test().

Changes:

  • server.auth.test() now returns an object with the properties
    • `credentials (required)
    • artifacts (optional)

PS: If merged, I’ll send another PR to update the docs

@hueniverse hueniverse self-assigned this Jan 13, 2019
@hueniverse hueniverse added this to the 18.0.0 milestone Jan 13, 2019
@hueniverse hueniverse merged commit ea108eb into hapijs:master Jan 13, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
hueniverse added a commit that referenced this pull request Jan 14, 2019
@marcuspoehls marcuspoehls deleted the futurestudio:server-auth-test-returns-artifacts branch Jan 14, 2019
@marcuspoehls
Copy link
Contributor Author

@marcuspoehls marcuspoehls commented Jan 14, 2019

@hueniverse Eran, thank you for the additional commit to update the API.md! Thanks for merging 😊

@lock
Copy link

@lock lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants