fix(transmit test): add missing await on team.work #3900
Merged
Conversation
|
As an fyi, I think the underlying principle that is being tested does work, but the test itself listen to the wrong event. |
|
Looks like this also breaks node 8. The same test on v16 on node 8 works (locally and CI) |
hueniverse
added a commit
that referenced
this pull request
Jan 14, 2019
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This break the test and shows the test doesn't actually work on node 10.
This points out something I bought up in #3899
This test is also broken on v16 on node 10 for probably the same reason.