Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transmit test): add missing await on #3900

merged 1 commit into from Jan 14, 2019


Copy link

This break the test and shows the test doesn't actually work on node 10.
This points out something I bought up in #3899
This test is also broken on v16 on node 10 for probably the same reason.

Copy link
Contributor Author

As an fyi, I think the underlying principle that is being tested does work, but the test itself listen to the wrong event.

Copy link
Contributor Author

Looks like this also breaks node 8. The same test on v16 on node 8 works (locally and CI)

@hueniverse hueniverse self-assigned this Jan 14, 2019
@hueniverse hueniverse added the test Test or coverage label Jan 14, 2019
@hueniverse hueniverse added this to the 18.0.0 milestone Jan 14, 2019
@hueniverse hueniverse merged commit 89604b0 into hapijs:master Jan 14, 2019
hueniverse added a commit that referenced this pull request Jan 14, 2019
@AdriVanHoudt AdriVanHoudt deleted the fix-test-803 branch January 14, 2019 08:48
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
test Test or coverage
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants