New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transmit test): add missing await on team.work #3900

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
2 participants
@AdriVanHoudt
Copy link
Member

AdriVanHoudt commented Jan 10, 2019

This break the test and shows the test doesn't actually work on node 10.
This points out something I bought up in #3899
This test is also broken on v16 on node 10 for probably the same reason.

@AdriVanHoudt

This comment has been minimized.

Copy link
Member Author

AdriVanHoudt commented Jan 10, 2019

As an fyi, I think the underlying principle that is being tested does work, but the test itself listen to the wrong event.

@AdriVanHoudt

This comment has been minimized.

Copy link
Member Author

AdriVanHoudt commented Jan 10, 2019

Looks like this also breaks node 8. The same test on v16 on node 8 works (locally and CI)

@hueniverse hueniverse self-assigned this Jan 14, 2019

@hueniverse hueniverse added the test label Jan 14, 2019

@hueniverse hueniverse added this to the 18.0.0 milestone Jan 14, 2019

@hueniverse hueniverse merged commit 89604b0 into hapijs:master Jan 14, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

hueniverse added a commit that referenced this pull request Jan 14, 2019

@AdriVanHoudt AdriVanHoudt deleted the AdriVanHoudt:fix-test-803 branch Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment