Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upfix(transmit test): add missing await on team.work #3900
Conversation
This comment has been minimized.
This comment has been minimized.
|
As an fyi, I think the underlying principle that is being tested does work, but the test itself listen to the wrong event. |
This comment has been minimized.
This comment has been minimized.
|
Looks like this also breaks node 8. The same test on v16 on node 8 works (locally and CI) |
AdriVanHoudt
referenced this pull request
Jan 11, 2019
Open
v16: look into compatibility with node 10 #3899
hueniverse
self-assigned this
Jan 14, 2019
hueniverse
added
the
test
label
Jan 14, 2019
hueniverse
added this to the 18.0.0 milestone
Jan 14, 2019
hueniverse
merged commit 89604b0
into
hapijs:master
Jan 14, 2019
added a commit
that referenced
this pull request
Jan 14, 2019
AdriVanHoudt
deleted the
AdriVanHoudt:fix-test-803
branch
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
AdriVanHoudt commentedJan 10, 2019
This break the test and shows the test doesn't actually work on node 10.
This points out something I bought up in #3899
This test is also broken on v16 on node 10 for probably the same reason.