Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropping node v12 support. There's a good discussion in #4279 that outlines other steps we may want to take as we end support for node v12. Here's my approach here:
??
in the place of||
when evaluating non-boolean expressions. I am open to other thoughts, but I am of the mind that it usually gives a better, more precise behavior than||
. In some cases I kept||
when I thought it made sense, e.g to fall through empty header values of''
.request._log()
which is called all over the place. I feel that we should adopt private methods in a given class only if we're willing to remove usage of_
-prefixed methods from that class that may be used by other classes.res.writeableEnd
rather thanres.finished
,req.socket
rather thanreq.connection
.AbortSignal
since I didn't want to make any substantive API changes, though I am in support of it.This PR will not pass CI until hapijs/shot#144 and hapijs/lab#1036 are published. I intend to publish beta versions of these (and other) modules in the near future.
Resolves #4279