Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Node v0.10 #736

Merged
merged 11 commits into from Apr 5, 2013

Conversation

Projects
None yet
3 participants
Owner

hueniverse commented Apr 5, 2013

Closes #651

@hueniverse hueniverse added a commit that referenced this pull request Apr 5, 2013

@hueniverse hueniverse Merge pull request #736 from spumko/v0.17
Node v0.10
cdf1953

@hueniverse hueniverse merged commit cdf1953 into master Apr 5, 2013

1 check passed

default The Travis build passed
Details
Owner

hueniverse commented Apr 5, 2013

@wpreul @thegoleffect Got a little trigger hapi after finally emerging from this streams2 brainwash that I had to merge. Please still review!

@hueniverse hueniverse deleted the v0.17 branch Apr 5, 2013

Owner

geek commented Apr 5, 2013

Looks good. Instead of .peek should it be named .preview and emit a 'data' event?

self.preview.on('data', ...

Owner

hueniverse commented Apr 5, 2013

I'm ok with preview. Not with data. I don't want to imply this is anything like an old stream. maybe just flip it. preview.on('peek')?

Owner

geek commented Apr 5, 2013

That sounds good to me.

Owner

hueniverse commented Apr 5, 2013

Done.

Contributor

thegoleffect commented Apr 5, 2013

Looks fine to me. I like the way the streams interface mimics the
consistency of Golang - just inherit, define a _read/_write, and works on
anything expecting a stream. Can't wait to play with it.

On Fri, Apr 5, 2013 at 11:45 AM, Eran Hammer notifications@github.comwrote:

Done.


Reply to this email directly or view it on GitHubhttps://github.com/spumko/hapi/pull/736#issuecomment-15973455
.

@jmonster jmonster pushed a commit to jmonster/hapi that referenced this pull request Feb 10, 2014

@hueniverse hueniverse Merge pull request #736 from spumko/v0.17
Node v0.10
dde10fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment