Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isAbsolutePath obsolete? #179

Closed
simon-p-r opened this issue Feb 29, 2016 · 5 comments
Closed

isAbsolutePath obsolete? #179

simon-p-r opened this issue Feb 29, 2016 · 5 comments
Assignees
Labels
Milestone

Comments

@simon-p-r
Copy link
Contributor

@simon-p-r simon-p-r commented Feb 29, 2016

This method is now include with all supported node versions so will you accept a PR to remove it? The method's tests currently break on Windows. Also another issue with testing on Windows are some of the tests for uniqueFilename fail.

@nlf

This comment has been minimized.

Copy link
Member

@nlf nlf commented Mar 31, 2016

yes, you're right about isAbsolutePath and I would definitely accept a PR removing it

If you can figure out a fix for the uniqueFilename stuff I'd be happy to merge that as well (as a separate PR), but we don't currently have automated testing for windows so we'll need to be careful there. Do you recall exactly what it is that fails?

@nlf nlf added the request label Mar 31, 2016
@simon-p-r

This comment has been minimized.

Copy link
Contributor Author

@simon-p-r simon-p-r commented Mar 31, 2016

I will take a look and submit 2 PRs for these

@kanongil

This comment has been minimized.

Copy link
Member

@kanongil kanongil commented Mar 31, 2016

Feel free to PR https://github.com/hapijs/inert as well, as it still uses this method.

@simon-p-r

This comment has been minimized.

Copy link
Contributor Author

@simon-p-r simon-p-r commented Mar 31, 2016

Ok will do 👍

@nlf nlf modified the milestone: 4.0.0 Apr 25, 2016
@nlf nlf closed this Apr 25, 2016
@fhemberger

This comment has been minimized.

Copy link

@fhemberger fhemberger commented May 3, 2016

PR for vision: hapijs/vision#84

@Marsup Marsup added feature and removed request labels Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.