Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepEqual does not check both sides in full #260

Closed
dominykas opened this issue Jun 19, 2018 · 2 comments
Closed

deepEqual does not check both sides in full #260

dominykas opened this issue Jun 19, 2018 · 2 comments
Assignees
Labels
bug
Milestone

Comments

@dominykas
Copy link

@dominykas dominykas commented Jun 19, 2018

I wasn't sure if this is a real issue or as designed, but it seems there were #127 and #130, which were meant to be fixed, however:

> hoek.deepEqual({ job: { jobId: 1 } }, { jobId: undefined });
false
> hoek.deepEqual({ jobId: undefined }, { job: { jobId: 1 } });
true
@Marsup

This comment has been minimized.

Copy link
Member

@Marsup Marsup commented Jun 19, 2018

#237 supposedly fixes that.

@kanongil

This comment has been minimized.

Copy link
Member

@kanongil kanongil commented Jun 19, 2018

#237 supposedly fixes that.

It does not, as it is caused by an another bug. It is however fixed in #242.

@kanongil kanongil added the bug label Jun 19, 2018
@hueniverse hueniverse added this to the 6.0.0 milestone Nov 1, 2018
@hueniverse hueniverse closed this Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.