Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set deepEqual() prototype option to true by default, not just when no options are passed #299

Closed
hueniverse opened this issue May 19, 2019 · 1 comment
Milestone

Comments

@hueniverse
Copy link
Member

@hueniverse hueniverse commented May 19, 2019

This is clearly a bug in the way default options are set, but it does create a breaking change.

Not sure if I should revert it or not.

@hueniverse hueniverse added this to the 6.2.3 milestone May 19, 2019
@kanongil

This comment has been minimized.

Copy link
Member

@kanongil kanongil commented May 20, 2019

Hmm, I'm not sure. Anyway, it doesn't seem to effect the usages in the hapi modules.

Note, there is still a case where the option is unset, where you might expect it to be the default value:

Hoek.deepEqual(Object.create(null), {}, { prototype: undefined });
@hueniverse hueniverse closed this May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.