Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflow in clone in v6.2.3 #300

Closed
dhalbrook opened this issue May 22, 2019 · 1 comment · Fixed by #301
Closed

Stack overflow in clone in v6.2.3 #300

dhalbrook opened this issue May 22, 2019 · 1 comment · Fixed by #301
Assignees
Labels
bug
Milestone

Comments

@dhalbrook
Copy link

@dhalbrook dhalbrook commented May 22, 2019

When updating to 6.2.3, we're seeing the following stack overflow:

(node:28550) UnhandledPromiseRejectionWarning: RangeError: Maximum call stack size exceeded
    at Object.exports.clone (/Users/dolan.halbrook/development/plugins/angular-li/limuirs/node_modules/@hapi/hoek/lib/index.js:25:26)
    at Object.exports.clone (/Users/dolan.halbrook/development/plugins/angular-li/limuirs/node_modules/@hapi/hoek/lib/index.js:116:36)
    at Object.exports.clone (/Users/dolan.halbrook/development/plugins/angular-li/limuirs/node_modules/@hapi/hoek/lib/index.js:116:36)
    at Object.exports.clone (/Users/dolan.halbrook/development/plugins/angular-li/limuirs/node_modules/@hapi/hoek/lib/index.js:116:36)
    at Object.exports.clone (/Users/dolan.halbrook/development/plugins/angular-li/limuirs/node_modules/@hapi/hoek/lib/index.js:116:36)
    at Object.exports.clone (/Users/dolan.halbrook/development/plugins/angular-li/limuirs/node_modules/@hapi/hoek/lib/index.js:116:36)
    at Object.exports.clone (/Users/dolan.halbrook/development/plugins/angular-li/limuirs/node_modules/@hapi/hoek/lib/index.js:116:36)
    at Object.exports.clone (/Users/dolan.halbrook/development/plugins/angular-li/limuirs/node_modules/@hapi/hoek/lib/index.js:116:36)
    at Object.exports.clone (/Users/dolan.halbrook/development/plugins/angular-li/limuirs/node_modules/@hapi/hoek/lib/index.js:116:36)
    at Object.exports.clone (/Users/dolan.halbrook/development/plugins/angular-li/limuirs/node_modules/@hapi/hoek/lib/index.js:116:36)

Our hapi modules:

    "@hapi/boom": "^7.2.1",
    "@hapi/h2o2": "^8.1.1",
    "@hapi/hapi": "^18.1.0",
    "@hapi/inert": "^5.1.0",
    "@hapi/joi": "^15.0.2",

If I pin @hapi/hoek to 6.2.2 this issue doesn't happen, so it's possibly caused by the changeset that was merged in 76a16ee

@dhalbrook

This comment has been minimized.

Copy link
Author

@dhalbrook dhalbrook commented May 23, 2019

Thanks for the quick fix!

@hueniverse hueniverse self-assigned this May 27, 2019
@hueniverse hueniverse added the bug label May 27, 2019
@hueniverse hueniverse added this to the 6.2.4 milestone May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.