Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance withShallow methods to support nested keys. Closes #109 #110

Merged
merged 2 commits into from Nov 27, 2014

Conversation

@hueniverse
Copy link
Member

hueniverse commented Nov 27, 2014

No description provided.

@hueniverse hueniverse added the feature label Nov 27, 2014
@hueniverse hueniverse added this to the 2.9.2 milestone Nov 27, 2014
@hueniverse hueniverse self-assigned this Nov 27, 2014
@hueniverse

This comment has been minimized.

Copy link
Member Author

hueniverse commented Nov 27, 2014

@nlf please review anyway

hueniverse added a commit that referenced this pull request Nov 27, 2014
enhance withShallow methods to support nested keys. Closes #109
@hueniverse hueniverse merged commit 5e543bb into master Nov 27, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@hueniverse hueniverse deleted the shallow branch Nov 27, 2014
@nlf

This comment has been minimized.

Copy link
Member

nlf commented Nov 27, 2014

Nice, I like this. Looks good.

I'm kind of debating the validity of making reachSet a little more robust and exporting it...

@hueniverse

This comment has been minimized.

Copy link
Member Author

hueniverse commented Nov 27, 2014

I would leave reachSet() alone for now, until we have a use case for exporting it. People are already using reach() too much (it's fucking slow).

@nlf

This comment has been minimized.

Copy link
Member

nlf commented Nov 27, 2014

That's true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.