Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upThrow error directly if it is the only thing passed in as the message #117
Conversation
This comment has been minimized.
This comment has been minimized.
mrlannigan
commented
Dec 16, 2014
|
|
This comment has been minimized.
This comment has been minimized.
|
Using an error as the argument incurs a relatively significant performance issue - since the Error is created before the condition is even tested. This pull request slightly improves performance because the current code will create two error objects if the assertion fails. We are now thinking of making a different repository that pre-registers error types, and then just passes in a string key in the assert. |
nlf
added a commit
that referenced
this pull request
Dec 22, 2014
Throw error directly if it is the only thing passed in as the message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ryanwilliamquinn commentedDec 10, 2014
For #116