Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for deep partial contain #134

Merged
merged 1 commit into from May 22, 2015
Merged

Allow for deep partial contain #134

merged 1 commit into from May 22, 2015

Conversation

@Marsup
Copy link
Member

Marsup commented Mar 25, 2015

This changes the behavior of contain to be able to deeply find properties without having an exact deep match.

Note that I'm still wondering why L288 didn't transmit its options and seen, it doesn't seem to change anything to the tests but I added it anyway.

@nlf nlf self-assigned this Mar 25, 2015
@nlf nlf added the feature label Mar 25, 2015
@Marsup Marsup force-pushed the Marsup:part-contain branch from 7f87b5d to 9bf5a4d Mar 26, 2015
@nlf

This comment has been minimized.

Copy link
Member

nlf commented May 22, 2015

Care to add some documentation for this? Implementation looks good to me

@nlf nlf added this to the 2.13.1 milestone May 22, 2015
@Marsup Marsup force-pushed the Marsup:part-contain branch from 9bf5a4d to f85e6f1 May 22, 2015
@Marsup

This comment has been minimized.

Copy link
Member Author

Marsup commented May 22, 2015

I don't see what documentation I should write, it's all in there already, looks like a bugfix to me.
I'm not sure documenting the part flag in deepEqual is really necessary since it's mostly for internal use.

@nlf nlf modified the milestones: 2.13.1, 2.14.0 May 22, 2015
@nlf nlf added bug and removed feature labels May 22, 2015
@nlf

This comment has been minimized.

Copy link
Member

nlf commented May 22, 2015

You're right, I forgot this was a bug fix and not a feature

nlf added a commit that referenced this pull request May 22, 2015
Allow for deep partial contain
@nlf nlf merged commit 1892cdd into hapijs:master May 22, 2015
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@Marsup Marsup deleted the Marsup:part-contain branch Sep 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.