Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(merge): use !== rather than ^ #180

Merged
merged 1 commit into from Apr 25, 2016
Merged

refactor(merge): use !== rather than ^ #180

merged 1 commit into from Apr 25, 2016

Conversation

@PatrickJS
Copy link
Contributor

PatrickJS commented Mar 30, 2016

No description provided.

@cjihrig

This comment has been minimized.

Copy link
Contributor

cjihrig commented Mar 31, 2016

Switching to XOR is cute, but way harder for people to understand at a glance.

@nlf

This comment has been minimized.

Copy link
Member

nlf commented Mar 31, 2016

it's also pointless to submit a pull request to do nothing but change one operator on one line. were you refactoring the whole method and needed to do so to understand the code better, sure, but what's the point here?

@Marsup

This comment has been minimized.

Copy link
Member

Marsup commented Mar 31, 2016

@cjihrig it's the other way around.

@nlf nlf added the request label Apr 25, 2016
@nlf nlf added this to the 4.0.0 milestone Apr 25, 2016
@nlf nlf self-assigned this Apr 25, 2016
@nlf nlf merged commit 517e4e6 into hapijs:master Apr 25, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PatrickJS PatrickJS deleted the PatrickJS:patch-1 branch Apr 25, 2016
@PatrickJS

This comment has been minimized.

Copy link
Contributor Author

PatrickJS commented Apr 25, 2016

thanks for merging!

@Marsup Marsup added feature and removed request labels Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.