Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upimprove .unique to make use of es6 `Set` performance #185
+80
−18
Conversation
This comment has been minimized.
This comment has been minimized.
|
It would be nice to add a test that differentiates the new behavior from the previous behavior (concerning the previous value coercion to string). |
| array.forEach((item) => { | ||
|
|
||
| const identifier = item[key]; | ||
| if (!index.has(identifier)) { |
This comment has been minimized.
This comment has been minimized.
nlf
Apr 6, 2016
Member
i wonder if it would be more efficient to build the set without checking .has (since sets don't allow duplicate members anyway), and then returning Array.from(theSet) like we do below. building both a set and an array at the same time seems wasteful.
This comment has been minimized.
This comment has been minimized.
…rsion
This comment has been minimized.
This comment has been minimized.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
catalint commentedApr 5, 2016
#184