Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Make contain see non-enumerable's #197

Merged
merged 1 commit into from Sep 19, 2016
Merged

Conversation

@blacksun1
Copy link
Contributor

blacksun1 commented Sep 17, 2016

The contain method would previously fail to see non-enumerable
properties. This change was performed by changing Object.keys for
Object.getOwnPropertyNames.

Also, added a bunch of extra assertions in the contain() tests objects
test for:

  • Assert that contains returns false on inherited members
  • Assert that contains returns true on non-enumerable members on the
    object

Fixes: #196

The contain method would previously fail to see non-enumerable
properties. This change was performed by changing `Object.keys` for
`Object.getOwnPropertyNames`.

Also, added a bunch of extra assertions in the `contain() tests objects`
test for:

* Assert that `contains` returns false on inherited members
* Assert that `contains` returns true on non-enumerable members on the
object

Fixes: 196
@nlf

This comment has been minimized.

Copy link
Member

nlf commented Sep 19, 2016

nice, this looks good. thanks!

@nlf nlf added the feature label Sep 19, 2016
@nlf nlf self-assigned this Sep 19, 2016
@nlf nlf added this to the 4.1.0 milestone Sep 19, 2016
@nlf nlf merged commit 8e92f28 into hapijs:master Sep 19, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.