Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try object ref comparison first in deepClone() #269

Merged
merged 1 commit into from Aug 10, 2018
Merged

Try object ref comparison first in deepClone() #269

merged 1 commit into from Aug 10, 2018

Conversation

@hueniverse
Copy link
Member

hueniverse commented Aug 10, 2018

No description provided.

@hueniverse hueniverse added the bug label Aug 10, 2018
@hueniverse hueniverse added this to the 5.0.4 milestone Aug 10, 2018
@hueniverse hueniverse self-assigned this Aug 10, 2018
@hueniverse hueniverse merged commit 3ab4511 into master Aug 10, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@hueniverse hueniverse deleted the dclonefast branch Aug 10, 2018
@kanongil

This comment has been minimized.

Copy link
Member

kanongil commented Aug 10, 2018

There is no bug here, right? Just a performance optimisation?

@hueniverse

This comment has been minimized.

Copy link
Member Author

hueniverse commented Aug 10, 2018

Yep. Just poor implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.