Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol support #281

Merged
merged 7 commits into from Nov 28, 2018
Merged

Symbol support #281

merged 7 commits into from Nov 28, 2018

Conversation

@kanongil
Copy link
Member

kanongil commented Nov 26, 2018

This adds Symbol support to all relevant api methods.

@kanongil kanongil added the feature label Nov 26, 2018
This was referenced Nov 26, 2018
@hueniverse hueniverse self-assigned this Nov 28, 2018
@hueniverse hueniverse added this to the 6.0.5 milestone Nov 28, 2018
const objSymbols = getOwnPropertySymbols(obj);
const refSymbols = new Set(getOwnPropertySymbols(ref));

for (let i = 0; i < objSymbols.length; ++i) {

This comment has been minimized.

Copy link
@hueniverse

hueniverse Nov 28, 2018

Member

Use for...of in the future.

This comment has been minimized.

Copy link
@kanongil

kanongil Nov 28, 2018

Author Member

Will do. Maybe we should update the style guide?

This comment has been minimized.

Copy link
@hueniverse
@hueniverse hueniverse merged commit b3b5134 into hapijs:master Nov 28, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Nov 28, 2018

This is actually a breaking change since most tests where objects have symbols will fail as-is.

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Nov 28, 2018

Going to change deepEqual to ignore symbols by default for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.