Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle promises in deepEqual() #294

merged 1 commit into from May 16, 2019


Copy link

kanongil commented May 5, 2019

This extends deepEqual() to handle the native Promise type by doing a simple reference comparison.

This fixes the current behaviour, where comparing promises essentially compares {} to {}, which always passes.

@hueniverse Promise comparisons need to be released before I can properly finalize the Promise support in #248.

@hueniverse hueniverse self-assigned this May 16, 2019
@hueniverse hueniverse added the bug label May 16, 2019
@hueniverse hueniverse added this to the 6.2.2 milestone May 16, 2019
@hueniverse hueniverse merged commit 0b90db7 into hapijs:master May 16, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.