Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone Map and Set #297

Merged
merged 13 commits into from May 17, 2019
Merged

Clone Map and Set #297

merged 13 commits into from May 17, 2019

Conversation

@kanongil
Copy link
Member

kanongil commented May 17, 2019

This is a continuation of #248, containing expanded and revised tests.

I decided to remove the Promise cloning altogether after some thought. The reason is that, with node native promises, it is impossible to do a clone without potentially changing the behavior of the source Promise. More specifically, attaching a catch handler means that it can no longer trigger an unhandledRejection process error.

@hueniverse hueniverse self-assigned this May 17, 2019
@hueniverse hueniverse added the feature label May 17, 2019
@hueniverse hueniverse added this to the 6.2.3 milestone May 17, 2019
@hueniverse hueniverse merged commit 76a16ee into hapijs:master May 17, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@hueniverse hueniverse added bug and removed feature labels May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.