Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty ref bug in contain when only is true #324

Merged
merged 5 commits into from Aug 12, 2019

Conversation

@samliebow
Copy link
Contributor

samliebow commented Aug 9, 2019

This fixes #323.

I added in some special logic for strings so that contain('', '') is still true and contain('', ['', '']) is true with any combo of flags as long as options.once is false. The latter is a change to the current behavior (contain('', ['', '']) is currently false), but I believe the current behavior there is also a bug.

@hueniverse hueniverse self-assigned this Aug 12, 2019
@hueniverse hueniverse added the bug label Aug 12, 2019
@hueniverse hueniverse added this to the 8.2.1 milestone Aug 12, 2019
@hueniverse hueniverse merged commit f135b5a into hapijs:master Aug 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hueniverse added a commit that referenced this pull request Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.