Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow falsey values to be used as default value in Hoek.reach() #88

Merged
merged 1 commit into from Oct 9, 2014

Conversation

@cjihrig
Copy link
Contributor

cjihrig commented Oct 2, 2014

Currently, values like null and '' cannot be used. This commit fixes that.

@hueniverse hueniverse added the bug label Oct 2, 2014
@arb arb added this to the 2.5.1 milestone Oct 9, 2014
@arb arb self-assigned this Oct 9, 2014
arb added a commit that referenced this pull request Oct 9, 2014
Allow falsey values to be used as default value in Hoek.reach()
@arb arb merged commit 25ed6ef into hapijs:master Oct 9, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@arb

This comment has been minimized.

Copy link
Contributor

arb commented Oct 9, 2014

@nlf please note the 2.5.1 milestone since this is technically a bug.

@cjihrig cjihrig deleted the cjihrig:falsey-default branch Oct 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.