Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially incorrect file responses when file is changed #4

Closed
kanongil opened this issue Oct 23, 2014 · 0 comments · Fixed by #8
Closed

Potentially incorrect file responses when file is changed #4

kanongil opened this issue Oct 23, 2014 · 0 comments · Fixed by #8
Assignees
Labels
bug
Milestone

Comments

@kanongil
Copy link
Member

@kanongil kanongil commented Oct 23, 2014

If a file is changed during file response processing, invalid responses are likely to be generated, including:

  • Content-Length, Last-Modified, and ETag header from old file, with new file data.
  • Trying to serve a non-existing file, responding with an ENOENT error.
  • Trying to serve a directory responding with an EISDIR error.

These issues should be able to be fixed by using a file descriptor and stat'ing / reading from it.

kanongil added a commit to kanongil/inert that referenced this issue Oct 27, 2014
kanongil added a commit to kanongil/inert that referenced this issue Oct 27, 2014
kanongil added a commit to kanongil/inert that referenced this issue Nov 4, 2014
kanongil added a commit to kanongil/inert that referenced this issue Nov 4, 2014
@hueniverse hueniverse added the bug label Nov 17, 2014
@kanongil kanongil self-assigned this Nov 19, 2014
kanongil added a commit to kanongil/inert that referenced this issue Nov 21, 2014
…phases

Also adds a 403 response for files with insufficient permissions.

Fixes hapijs#4
kanongil added a commit to kanongil/inert that referenced this issue Nov 26, 2014
Additionally adds a 403 response for files with insufficient permissions.

Fixes hapijs#4
kanongil added a commit to kanongil/inert that referenced this issue Nov 26, 2014
@kanongil kanongil added this to the 2.0.0 milestone Mar 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.