Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #76

Closed
hueniverse opened this issue Nov 29, 2016 · 3 comments
Closed

Update deps #76

hueniverse opened this issue Nov 29, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@hueniverse
Copy link
Member

@hueniverse hueniverse commented Nov 29, 2016

No description provided.

@hueniverse hueniverse added this to the 4.0.3 milestone Nov 29, 2016
@hueniverse hueniverse self-assigned this Nov 29, 2016
@kanongil

This comment has been minimized.

Copy link
Member

@kanongil kanongil commented Nov 29, 2016

@hueniverse How do we handle the subtle .boolean() breakage in the Joi schemas? There is a chance that someone relies on it handling eg "false", and the update breaks their existing install as it is.

@kanongil kanongil reopened this Nov 29, 2016
@kanongil

This comment has been minimized.

Copy link
Member

@kanongil kanongil commented Nov 29, 2016

Oh, you already published this as a patch release. Guess we just wait and see then..

@kanongil kanongil closed this Nov 29, 2016
@hueniverse

This comment has been minimized.

Copy link
Member Author

@hueniverse hueniverse commented Nov 29, 2016

I'm not too worried about it and it will block the process from starting so it's an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.