Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory listing has broken links #124

Merged
merged 3 commits into from Sep 12, 2019
Merged

Conversation

@MariiaZimokha
Copy link

MariiaZimokha commented Dec 21, 2018

I came across with this issue #119.
As was described, when we hit top level path, then links are built incorrectly "/logstrace_context.log".
It's just happening when stripTrailingSlash is set true or last slash is omitted.

We need to be sure when we hit top level path, we have slash at the end of it.

Tests were added and coverage wasn't decreased.

}
});

const res = await server.inject('/showindex/');

This comment has been minimized.

Copy link
@MariiaZimokha

MariiaZimokha Dec 21, 2018

Author

To see an error, just delete last /

const res = await server.inject('/showindex');
@hueniverse hueniverse self-assigned this Sep 12, 2019
@hueniverse hueniverse added the bug label Sep 12, 2019
@hueniverse hueniverse merged commit 3a1d137 into hapijs:master Sep 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hueniverse hueniverse added this to the 5.2.2 milestone Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.