Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal rewrite to async / await #97

Merged
merged 3 commits into from Sep 19, 2017
Merged

Conversation

@kanongil
Copy link
Member

kanongil commented Sep 19, 2017

All internal logic has been rewritten to use async / await.

It is still targets hapi@16 for the interface, but should be simple to update. To fully target v17, all tests needs to be rewritten.

@hueniverse hueniverse modified the milestones: 4.2.1, 5.0.0 Sep 19, 2017
@hueniverse hueniverse merged commit 06f87fc into hapijs:master Sep 19, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hueniverse added a commit that referenced this pull request Sep 20, 2017
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Sep 20, 2017

@kanongil see my follow up commit.

@kanongil

This comment has been minimized.

Copy link
Member Author

kanongil commented Sep 20, 2017

Look good.

Shouldn't the generateResponse() life-cycle methods also be updated to async to complete the conversion?

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Sep 20, 2017

Yes, also marshal and prepare... This is a deep rabbit hole...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.