Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upadded digest argument to crypto.pbkdf2 #43
Merged
Conversation
- it's an optional argument that in node 6 became non-optional - also added 5th arg to mock Crypto.pbkdf2 in test
nfcampos
force-pushed the
nfcampos:add-digest-to-pbkdf2
branch
2 times, most recently
from
7948602
to
9e0a1ef
This comment has been minimized.
This comment has been minimized.
|
could you release a version with this fix? |
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Sep 13, 2016
As of Node 6, crypto.pbkdf emits a deprecation warning when the digest isn't explicily set. Under certain conditions we are seeing this warning from Hapi's dependency Iron. Iron resolved this issue as of 4.0.4, which was introduced into Hapi as of 14.0.0. Since the level of effort appeared to be similar, I decided to bump us to the current version of Hapi. Node deprecation: nodejs/node#4047 Iron's resolution: hapijs/iron#43 As of Hapi v9, they have removed three build-in plugins from the core which we rely on inert (files and directories), vision (view templates), and h2o2 (proxy). hapijs/hapi#2682 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Sep 13, 2016
As of Node 6, crypto.pbkdf emits a deprecation warning when the digest isn't explicily set. Under certain conditions we are seeing this warning from Hapi's dependency Iron. Iron resolved this issue as of 4.0.4, which was introduced into Hapi as of 14.0.0. Since the level of effort appeared to be similar, I decided to bump us to the current version of Hapi. Node deprecation: nodejs/node#4047 Iron's resolution: hapijs/iron#43 As of Hapi v9, they have removed three build-in plugins from the core which we rely on inert (files and directories), vision (view templates), and h2o2 (proxy). hapijs/hapi#2682 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Sep 14, 2016
As of Node 6, crypto.pbkdf emits a deprecation warning when the digest isn't explicily set. Under certain conditions we are seeing this warning from Hapi's dependency Iron. Iron resolved this issue as of 4.0.4, which was introduced into Hapi as of 14.0.0. Since the level of effort appeared to be similar, I decided to bump us to the current version of Hapi. Node deprecation: nodejs/node#4047 Iron's resolution: hapijs/iron#43 As of Hapi v9, they have removed three build-in plugins from the core which we rely on inert (files and directories), vision (view templates), and h2o2 (proxy). hapijs/hapi#2682 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nfcampos commentedApr 29, 2016
•
edited
(I made the digest be the its default value in previous node versions (https://nodejs.org/dist/latest-v4.x/docs/api/crypto.html#crypto_crypto_pbkdf2_password_salt_iterations_keylen_digest_callback) so the behaviour is unchanged)