Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added digest argument to crypto.pbkdf2 #43

Merged
merged 1 commit into from Apr 29, 2016

Conversation

@nfcampos
Copy link
Contributor

nfcampos commented Apr 29, 2016

  • it's an optional argument that in node 6 became non-optional
  • also added 5th arg to mock Crypto.pbkdf2 in test

(I made the digest be the its default value in previous node versions (https://nodejs.org/dist/latest-v4.x/docs/api/crypto.html#crypto_crypto_pbkdf2_password_salt_iterations_keylen_digest_callback) so the behaviour is unchanged)

- it's an optional argument that in node 6 became non-optional
- also added 5th arg to mock Crypto.pbkdf2 in test
@nfcampos nfcampos force-pushed the nfcampos:add-digest-to-pbkdf2 branch 2 times, most recently from 7948602 to 9e0a1ef Apr 29, 2016
@hueniverse hueniverse added the bug label Apr 29, 2016
@hueniverse hueniverse self-assigned this Apr 29, 2016
@hueniverse hueniverse merged commit d34d019 into hapijs:master Apr 29, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hueniverse hueniverse added this to the 4.0.1 milestone Apr 29, 2016
@nfcampos nfcampos deleted the nfcampos:add-digest-to-pbkdf2 branch Apr 29, 2016
@nfcampos

This comment has been minimized.

Copy link
Contributor Author

nfcampos commented May 9, 2016

could you release a version with this fix?

tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Sep 13, 2016
As of Node 6, crypto.pbkdf emits a deprecation warning when the digest isn't explicily set. Under certain conditions we are seeing this warning from Hapi's dependency Iron. Iron resolved this issue as of 4.0.4, which was introduced into Hapi as of 14.0.0. Since the level of effort appeared to be similar, I decided to bump us to the current version of Hapi.

Node deprecation: nodejs/node#4047
Iron's resolution: hapijs/iron#43

As of Hapi v9, they have removed three build-in plugins from the core which we rely on inert (files and directories), vision (view templates), and h2o2 (proxy). hapijs/hapi#2682

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Sep 13, 2016
As of Node 6, crypto.pbkdf emits a deprecation warning when the digest isn't explicily set. Under certain conditions we are seeing this warning from Hapi's dependency Iron. Iron resolved this issue as of 4.0.4, which was introduced into Hapi as of 14.0.0. Since the level of effort appeared to be similar, I decided to bump us to the current version of Hapi.

Node deprecation: nodejs/node#4047
Iron's resolution: hapijs/iron#43

As of Hapi v9, they have removed three build-in plugins from the core which we rely on inert (files and directories), vision (view templates), and h2o2 (proxy). hapijs/hapi#2682

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Sep 14, 2016
As of Node 6, crypto.pbkdf emits a deprecation warning when the digest isn't explicily set. Under certain conditions we are seeing this warning from Hapi's dependency Iron. Iron resolved this issue as of 4.0.4, which was introduced into Hapi as of 14.0.0. Since the level of effort appeared to be similar, I decided to bump us to the current version of Hapi.

Node deprecation: nodejs/node#4047
Iron's resolution: hapijs/iron#43

As of Hapi v9, they have removed three build-in plugins from the core which we rely on inert (files and directories), vision (view templates), and h2o2 (proxy). hapijs/hapi#2682

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.