Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): remove unused hoek dependency #7

Merged
merged 1 commit into from Feb 16, 2018

Conversation

@wraithgar
Copy link
Contributor

wraithgar commented Feb 16, 2018

Hoek had an advisory come up on nsp. When I went to look at where it was used to see if this package was vulnerable, it appeared to me to not be in use anymore.

I removed hoek from package.json, all the tests still pass.

@Marsup

This comment has been minimized.

Copy link
Member

Marsup commented Feb 16, 2018

Indeed, but hoek has been fixed so it shouldn't change anything. Thanks.

@Marsup Marsup self-assigned this Feb 16, 2018
@Marsup Marsup added the dependency label Feb 16, 2018
@Marsup Marsup merged commit 8e1af64 into hapijs:master Feb 16, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk No new issues
Details
@Marsup Marsup added this to the 1.1.1 milestone Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.